search

mlabs-haskell / cardano-open-oracle-protocol

COOP - Cardano open oracle protocol
Apache License 2.0
21 stars 3 forks source link

Write a document elaborating on the Plutus Json specification #50

Closed bladyjoker closed 1 year ago

bladyjoker commented 1 year ago

As per #38 the support for generic conversions between Json and Plutus Data format was implemented in coop-extras/plutus-json and is used by a generic Json Fact Statement Store service implementation in coop-extras/json-fact-statement-store.

To have a well rounded and a complete feature we must provide a short specification document elaborating on the format mapping.

bladyjoker commented 1 year ago

@ross-spencer this is basically what we need to document in Human readable form. https://github.com/mlabs-haskell/cardano-open-oracle-protocol/blob/b475f338954dfe55d707bfea30d90a4fdcc1c952/coop-extras/plutus-json/src/PlutusJson.hs#L50

ross-spencer commented 1 year ago

@GeorgeFlerovsky thanks for this write-up: https://github.com/mlabs-haskell/cardano-open-oracle-protocol/pull/65#event-8369637342 cc. @peterVG

We should probably find a neat way to link to this in the README.md at the root level, or are there better places to link to it from?

GeorgeFlerovsky commented 1 year ago

@GeorgeFlerovsky thanks for this write-up: https://github.com/mlabs-haskell/cardano-open-oracle-protocol/pull/65#event-8369637342 cc. @peterVG

We should probably find a neat way to link to this in the README.md at the root level, or are there better places to link to it from?

Yeah, that's a good idea. Go ahead 👍

ross-spencer commented 1 year ago

Oh, wait, @bladyjoker already took care of it: https://github.com/mlabs-haskell/cardano-open-oracle-protocol/commit/cf3b94571c96abc99e82aa2548d1634f9b6ffbc6 (https://github.com/mlabs-haskell/cardano-open-oracle-protocol/pull/67) thanks Dražen!