mlabs-haskell / nft-marketplace-server

2 stars 2 forks source link

Seabug depends on `release.nix` but it was removed #35

Closed rynoV closed 2 years ago

rynoV commented 2 years ago

Just realized seabug depends on the release.nix file, see here, #34 removed it though.

rynoV commented 2 years ago

cc @t4ccer , will we just add it back, or is there a better way to do what release.nix was doing?

t4ccer commented 2 years ago

Oh seabug isn't flakified yet, copy default.nix from ODC to here and use it in the same way

rynoV commented 2 years ago

I copied the default.nix from ODC and updated that line in arion-compose.nix to reference default.nix instead of release.nix getting an error:

error: 'functionArgs' requires a function

       at /nix/store/1i9xy4a7dnyr4binxz17kda79n48ayxb-nixpkgs/nixpkgs/lib/trivial.nix:443:10:

          442|     then f.__functionArgs or (lib.functionArgs (f.__functor f))
          443|     else builtins.functionArgs f;
             |          ^
          444|

No idea about this, and the previous version is working, so I'm going to leave this for now

t4ccer commented 2 years ago

Push it to some branch, I'll look into it

rynoV commented 2 years ago

Sure:

https://github.com/mlabs-haskell/nft-marketplace-server/tree/calum/35-replace-release-nix https://github.com/mlabs-haskell/seabug/tree/calum/update-nft-marketplace-server

t4ccer commented 2 years ago

I've pushed one commit to https://github.com/mlabs-haskell/seabug/tree/calum/update-nft-marketplace-server

rynoV commented 2 years ago

Oops yeah my bad, should have figured to do that!

rynoV commented 2 years ago

@t4ccer I tried that change and I'm still getting the same error

t4ccer commented 2 years ago

I would swear it worked before... Try now please

arion build ogmios-datum-cache and arion build nft-marketplace-server work at least on my machine now

rynoV commented 2 years ago

That works now, thanks! I'll open PRs