search

mlabs-haskell / ogmios-datum-cache

6 stars 4 forks source link

Reinvention of protocol types for ogmios #69

Open ryukzak opened 2 years ago

ryukzak commented 2 years ago

Right now, we redefine data types to work with ogmios: OgmiosRequestNextResponse

But ogmios already have them: https://github.com/CardanoSolutions/ogmios/blob/39426ceb420adc26fbe70b9c5681905c8d34add3/server/src/Ogmios/Data/Protocol/ChainSync.hs#L175

Actually, we can reuse it.

micahkendall commented 2 years ago

Is there a way to reach these types without depending on the entirety of Ogmios? Otherwise, I'd say we just keep a note down to ctrl+f the Ogmios source code whenever we're adding new types.

ryukzak commented 2 years ago

I am more afraid about dependency on ouroboros-network, etc, which can make dependency management significantly harder. So right now, I don't sure that it is a good idea in general.