mlabs-haskell / seabug-contracts

3 stars 1 forks source link

Fix wallet connection logic #36

Closed nrutledge closed 2 years ago

nrutledge commented 2 years ago

seabug-contracts doesn't currently expose any function for connecting the wallet. This function was present prior to moving Seabug offchain logic out of the main CTL repo. It either needs to get added back or we need to change how the frontend connects to the wallet.

Original implementation:

samuelWilliams99 commented 2 years ago

is this a blocker for getting the code to Volo? @rynoV appears to have been able to test still?

rynoV commented 2 years ago

@samuelWilliams99 It shouldn't be blocker, the main features are working without the wallet connection logic. Not sure exactly what the logic was used for, but it looks like it should be pretty quick to add back

nrutledge commented 2 years ago

If this still works as it did previously, the user will get prompted automatically to connect their Nami wallet as soon as the first CTL query runs (i.e., on page load). In that case, it's definitely not a blocker.

However, I don't know how this works with multiple wallets. We really want the user to be able to click the wallet icon at the top right of the page and connect to their desired wallet.

rynoV commented 2 years ago

the user will get prompted automatically to connect their Nami wallet as soon as the first CTL query runs (i.e., on page load)

Just checked and this is the case (I unwhitelisted localhost and the prompt showed up when I reloaded)

KindaSloth commented 2 years ago

Solved in #43