Updating CTL version, fixing for breaking changes

rynoV commented 2 years ago

Closes #37 and #30

Changes:

TODO:

[x] Move away from extraConfig
- This feature of CTL is going to be removed eventually, I think I may as well refactor while I'm doing this migration
- I tried a custom monad stack here, it's not much better than just passing an extra parameter to the contracts that need the projectId
- We could make it nicer by implementing our own liftX functions to make interoperating with all of CTL's Contract functions easier, but I don't think it's worth it right now
[x] Make sure to properly reuse contract environment (websocket connections, etc.)
- This PR is on par with master in terms of the number of websocket connections
- It might be possible to refactor so that the contract environment is reused across contract calls, but I think that's premature optimization at this point
[ ] Hopefully integrate fixes for https://github.com/Plutonomicon/cardano-transaction-lib/issues/803 because we're also seeing the issue described there
- The issue isn't breaking the app though, so we could merge without it

rynoV commented 2 years ago

I assume merging this will mean we'll need to update the ctl ref in the monorepo as well?

It would probably be for the best. Maybe we should merge into some kind of staging branch instead?

samuelWilliams99 commented 2 years ago

Perhaps, but it's a relatively uncommon change, I think it's fine to just pr both of them the subrepo should be commit locked anyway

rynoV commented 2 years ago

mlabs-haskell / seabug-contracts