search

mlabs-haskell / seabug-contracts

3 stars 1 forks source link

Wallet Connection #43

Closed KindaSloth closed 2 years ago

KindaSloth commented 2 years ago

36

This PR adds and exports a function to connect to Nami or Gero wallet.

Quick video connecting in the front:

https://user-images.githubusercontent.com/55771765/183759438-252eef05-47e9-4315-a8ff-0bf1d518362e.mp4

KindaSloth commented 2 years ago

@samuelWilliams99 I opened the PR just here adding/exporting the function, should I open a PR in the nft-marketplace doing the integration?

samuelWilliams99 commented 2 years ago

Given the "no nfts found", @rynoV, could you run this with your testnet node? I'd like to know if the nfts will show up without a wallet connection

rynoV commented 2 years ago

I opened the PR just here adding/exporting the function, should I open a PR in the nft-marketplace doing the integration?

@Guilherme775 Yeah if you have some code changes there just open a PR, even if it's just a draft

rynoV commented 2 years ago

I'd like to know if the nfts will show up without a wallet connection

@samuelWilliams99 It's the same as before, where if nami isn't connected on pageload the website prompts me to connect nami, then loads normally

samuelWilliams99 commented 2 years ago

Okay - part of this PR needs to be to remove that behaviour, and allow the contracts to query nfts without knowing own pubkeyhash. @Guilherme775 could you look into this? I'd start by verifying with the CTL team whether or not this is even possible

KindaSloth commented 2 years ago

@samuelWilliams99 just remove Nami from walletSpec pretty easy, now the NFTs are listed without connecting the wallet

samuelWilliams99 commented 2 years ago

@samuelWilliams99 just remove Nami from walletSpec pretty easy, now the NFTs are listed without connecting the wallet

Right - do buy transactions still work after you link your wallet? Does it always use the most recently linked wallet?

KindaSloth commented 2 years ago

@samuelWilliams99 just remove Nami from walletSpec pretty easy, now the NFTs are listed without connecting the wallet

Right - do buy transactions still work after you link your wallet? Does it always use the most recently linked wallet?

Yep, seems to be working fine

KindaSloth commented 2 years ago

After merge this, would be good review/merge this one: https://github.com/mlabs-haskell/nft-marketplace/pull/227