search

mlabs-haskell / seabug-contracts

3 stars 1 forks source link

Move Metadata code from CTL #7

Closed samuelWilliams99 closed 2 years ago

samuelWilliams99 commented 2 years ago

Addresses #9

rynoV commented 2 years ago

@samuelWilliams99 Using the changes from here and also my change described here I was able to test this out; listing NFTs seems to be working, but I get Error: marketplaceBuy: NFT not found on marketplace when I try to buy an NFT, I'm not sure if this is expected right now.

For this repository, this is the commit I used for testing (I merged my changes with that commit). Maybe I should change the base branch to aleksandr/fd-to-nix-develop or push the merge commit to this branch?

PS I messed up some commits and did some force pushing to get things back to the way they were, no changes have been made, but I'm not sure how to get CI to run again.

rynoV commented 2 years ago

If you could also submit a quick PR to CTL removing the code you've copied here

@samuelWilliams99 In CTL there are some tests for the seabug code, should I work on moving those over to this repository? This project doesn't seem to have testing set up yet and I'm not entirely sure how it should be done, but I can try to copy the setup from the CTL repo

samuelWilliams99 commented 2 years ago

Agreed, let's try move over the minimal setup needed to run said tests

samuelWilliams99 commented 2 years ago

Regarding buy - known issue, and regarding tests - you can push an empty commit if you'd like