mlabs-haskell / spo-anywhere

Install Cardano nodes anywhere with the help of NixOS
https://mlabs-haskell.github.io/spo-anywhere/
Apache License 2.0
1 stars 0 forks source link

Automatically update inputs using the flake-update Hercules CI effect #13

Open aciceri opened 7 months ago

aciceri commented 7 months ago

Not directly part of the milestone but it should easy and useful. For now I wouldn't enable autoMerge.

zmrocze commented 7 months ago

included in #15, not to generate unnecessary merges, this is small change

zmrocze commented 7 months ago

How to treat node updates?

Firstly, not all master commits in cardano-node pass their CI, so I would rely on releases (maybe we can ask them to create a release branch? because their master is really develop).

Secondly, do we need to support few node versions explicitly? Or is it enough that users can always overwrite cardano-node input. My opinions is that's enough, let's keep using latest mainnet.

aciceri commented 7 months ago

Firstly, not all master commits in cardano-node pass their CI, so I would rely on releases (maybe we can ask them to create a release branch? because their master is really develop).

Agree :+1:

Secondly, do we need to support few node versions explicitly? Or is it enough that users can always overwrite cardano-node input. My opinions is that's enough, let's keep using latest mainnet.

For now I would target one release and manually update it when needed. If we manually specify a release as our input flake-update will not update it obviously. It would be nice targetting multiple versions but we have enough to do for this milestone.

zmrocze commented 7 months ago

https://github.com/IntersectMBO/cardano-node/issues/5661