search

mlachwani / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Using explicit unicode strings with non explicit unicode api #341

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
A comment on the code and the use of the Win32 API.

The source files assumes UNICODE to be globally defined. It uses 
LoadLibrary() with explicit L"unicode" strings.

Since LoadLibrary is either LoadLibraryA or LoadLibraryW .. then the use 
of L"" explicitly takes out this API flexibility.

I suggest using _T("") or _TEXT("") for a wider range of users. I.E. Those 
who does not globally accept UNICODE to be defined.

Another option is 
{{{
#ifndef UNICODE
#define UNICODE
#endif
}}}
before including windows headers.

Thanks for maintaining this project.

Original issue reported on code.google.com by daher.al...@gmail.com on 29 Oct 2009 at 3:05