Fix for #20 - Githubissues

mlaiacker / rosbag2video

converts image sequence in ros bag files to video files

GNU General Public License v2.0

313 stars 111 forks source link

Fix for #20 #41

Open cardboardcode opened 1 month ago

cardboardcode commented 1 month ago

Purpose of Pull Request :bookmark:

This aims to fix the issue highlighted in #20 which was reproducable by doing the following:

Steps To Reproduce :books:

Download rosbag2video:

cd $HOME

git clone https://github.com/mlaiacker/rosbag2video --depth 1 --single-branch --branch master && cd rosbag2video

Ensure you have in the root of the repo.

Run ROS 1 rosbag2video.py script:

source /opt/ros/noetic/setup.bash && python3 rosbag2video.py -t <ros1_image_topic_name> <ros1_bag_file_name>

Run Step 3 again.

The cause of issue was determined to be due to having the output video file of the same name present after the first generation.

Summary :bookmark_tabs:

Implement feature that automatically generates unique timestamps and appends it to the output video file name.

Remarks :speech_balloon:

@mlaiacker May I get your help to do a quick 15 minute review and approve if you have the time?