search

mlajtos / mosaic

A tiling web browser.
MIT License
106 stars 4 forks source link

Interested in contributing #7

Closed marc2332 closed 4 years ago

marc2332 commented 4 years ago

Hello!

I just found mosaic... and I am pretty amazed by the idea!

Is there any Discord server for it?

I would like to contribute, I have experience with Electron and a bit with React 😄 👍🏻

mlajtos commented 4 years ago

Hello marc2332 and welcome 🙂

Currently there is no Discord server. However, you are free to create it. I was hoping that Github Discussions would be out of beta by now, but not yet.

About the contribution – main short-term focus is to get Mosaic into state where one can use it as a casual daily driver. There are 3 obvious showstoppers:

  1. Shortcuts for keyboard users, e.g. it is not obvious what tab to close when you press Ctrl-W (⌘W) in split-screen
  2. Small tweaks for mouse users, e.g. there is no button for a new tab, click on dock icons doesn't do anything
  3. Ability to use Google services – right now you are not able to login into Google products 1 because it detects that the app is an Electron app.

Having these covered, we can use Mosaic on a daily basis, and the closed feedback loop will yield next targets.

Of course, this is my view – the best course of action for you is to download it, try it out and see for yourself what bothers you. There is a lot to be done!

1 Using Google Meet in split-screen is one of the use cases where Mosaic can really shine.

mlajtos commented 4 years ago

Hey @marc2332, checkout #8 which is a good first issue.

marc2332 commented 4 years ago

About the Discord server, I think it would be great to have one since it allows a more direct communication with the users and the devs.

Also, I have some some thoughts about mosaic:

  1. The titlebar is not showing in Windows imagen

    I don't know if that's intended but in your screenshot in the readme it shows the traffic lights of MacOS

  2. The ctrl+w shortcut doesn't close any tab, it just closes the entire app

But all the other looks so cool! I am going to take a look at the Finding text issue 👍🏻 😄

marc2332 commented 4 years ago

Also, I see no reasons to always maximize the window when opening. https://github.com/mlajtos/mosaic/blob/64107ac344cf3f30124a2a1864c1875cbb6c04b3/src/main/index.js#L31

I would suggest using something like electron-window-state https://www.npmjs.com/package/electron-window-state to preserve the window position and size after closing

mlajtos commented 4 years ago

I converted your suggestions into issues. Closing this one.