Reported by hoehna on 2013-11-11 10:26 UTC
Reviewing the code I found that several instances when the refCount variable of smart pointers was not initialized properly.
My thinking is that smart pointers is unnecessary in a compiler. Reference counting can be done through the VariableSlot or Variable classes, or using other compiler (revlanguage) classes that we need anyway. Smart pointers only cause unnecessary overhead.
Anyway, if we decide to keep them they need to be implemented correctly and consistently to serve any purpose...
Reported by hoehna on 2013-11-11 10:26 UTC Reviewing the code I found that several instances when the refCount variable of smart pointers was not initialized properly.
My thinking is that smart pointers is unnecessary in a compiler. Reference counting can be done through the VariableSlot or Variable classes, or using other compiler (revlanguage) classes that we need anyway. Smart pointers only cause unnecessary overhead.
Anyway, if we decide to keep them they need to be implemented correctly and consistently to serve any purpose...