mlange-42 / yarner

Literate Programming command line tool for Markdown
https://mlange-42.github.io/yarner
MIT License
32 stars 1 forks source link

Remove concrete abstractions #46

Closed adamreichold closed 3 years ago

adamreichold commented 3 years ago

I guess this more controversial as it not does not simplify things very much as it just removes traits that have only a single implementation and only starts on the way towards standardizing all error types to Box<dyn Error>. But then again, all the Markdown parsing code is now in place and simplification can start in earnest and it is a first step towards dropping the library-like heritage of much of the code which IMHO is unhelpful over-generalization for the program by now.

mlange-42 commented 3 years ago

I was also thinking about dropping all the now unnecessary traits in parser/mod.rs. As I don't expect other parsers than Markdown to be added soon (or at all), I am happy with that.