mlange-42 / yarner

Literate Programming command line tool for Markdown
https://mlange-42.github.io/yarner
MIT License
32 stars 1 forks source link

[Withdrawn] Task-oriented module structure #87

Closed mlange-42 closed 3 years ago

mlange-42 commented 3 years ago

[Withdrawn] Still here for comparison with step-wise re-structuring.

A trial to restructure according #57.

So far:

@adamreichold Any advice, or an independent trial, is highly appreciated.

adamreichold commented 3 years ago

Any advice, or an independent trial, is highly appreciated.

Instead of a duplicate approach, I would prefer making this easier to review by breaking it up. For example, create on new module per pull request. Or even smaller steps. (Of course, I can look at individual commits here, but the discussion should be scoped as well. And since you already have individual commits, it should also be straight forward to break this into independent pull requests.)

mlange-42 commented 3 years ago

I tried to break it into commits, but it was not possible to do it module by module. I can, however, start with a MR for the first commit.

mlange-42 commented 3 years ago

My impression was that this is basically only moving around code, so the overall structure changes but content not. So I thought you would primarily focus on the overall structure rather than diffs, anyway. But maybe more places for improvement become obvious by doing it step by step.

adamreichold commented 3 years ago

But maybe more places for improvement become obvious by doing it step by step.

Often, doing larger reshuffling of a code base is also used to tease out other improvements since you are reading through all of it anyway.

mlange-42 commented 3 years ago

Done in #89, #98, #99, #102, #103, #104.