mlarrieux / BME547_F22_repo

A repo for my classwork for BME547 F22
0 stars 0 forks source link

are these formatted as strings and floats to the extent to which the project intends? #16

Open mlarrieux opened 1 year ago

mlarrieux commented 1 year ago

Float values returned within messages:

https://github.com/mlarrieux/BME547_F22_repo/blob/f5b91b31ec4a64dfe6a86c3a462eb8d29adb3a0f/time_server.py#L49

https://github.com/mlarrieux/BME547_F22_repo/blob/f5b91b31ec4a64dfe6a86c3a462eb8d29adb3a0f/time_server.py#L87

String values returned within messages:

https://github.com/mlarrieux/BME547_F22_repo/blob/f5b91b31ec4a64dfe6a86c3a462eb8d29adb3a0f/time_server.py#L31

https://github.com/mlarrieux/BME547_F22_repo/blob/f5b91b31ec4a64dfe6a86c3a462eb8d29adb3a0f/time_server.py#L23

dward2 commented 1 year ago

Strictly speaking, you should only return the date or time in the string, not your text that says "The date is...". Same for age. It should only be the number (sent as a json string).

dward2 commented 1 year ago

Also, this assignment should be done in the GitHub classroom repo setup for this assignment. Go to Sakai and.lool for the Time Server assignment and create a repo there. Then, more this code into that private repo.

mlarrieux commented 1 year ago

Can i leave the formatting for the time to breakfast, lunch, and dinner then? Including the context line that always prints that reads:

"Breakfast occurs at 8:00am, Lunch at 12:30pm,"\ " and Dinner at 7:00pm.

"

In addition, I assume your formatting include jsonify() for the two strings from time and date. For age and time to next meal, if these are supposed to be floats does that mean I should not do jsonify()?