search

mlaursen / react-md

React material design - An accessible React component library built from the Material Design guidelines in Sass
https://react-md.dev
MIT License
2.34k stars 298 forks source link

[Tabs] Tab indicator height cannot be overridden #764

Closed doug2k1 closed 5 years ago

doug2k1 commented 6 years ago

Description

The Sass variable md-tab-indicator-height seems to have no effect. The value of 2px is always set inline by this line of code:

https://github.com/mlaursen/react-md/blob/master/src/js/Tabs/TabIndicator.js#L19

There is a way to customize the tab indicator height?

Version

nielswh commented 6 years ago

I'm also having the same issue. There looks to be inline style for the height in TabIndicator. Anyway this could read in the value for md-tab-indicator-height instead of defaulting to 2?

mlaursen commented 5 years ago

There should now be a prop exposed in the Tabs component to fix this named indicatorHeight which defaults to 2.