mlava / send-readwise

3 stars 0 forks source link

Does not work at all #4

Closed tombarys closed 1 year ago

tombarys commented 1 year ago

Hi, Mark, I have problem using the plugin. It does not work at all, console returns "Error: 400". I had the same problem with my own cljs Readwise plugin and two things helped: I both replaced URL backlinking using "Roam desktop links" to standard full URLs (strange) and finally: I removed sending empty note ("") when there was no note at all. Now my plugin works again, but your plugin does not work. Thanks!

mlava commented 1 year ago

Thanks for reporting. I will look, but thought I already had logic in there to handle empty strings. Will check and return. Cheers!

mlava commented 1 year ago

@tombarys I can't reproduce this at all. I've tried all the various settings and it appears to work fine. I have no console errors. Is this resolved for you??

tombarys commented 1 year ago

Hi, it does not work for me... this is the console error message: >POST https://readwise.io/api/v2/highlights/ 400.

mlava commented 1 year ago

Hey Tomáš, I know this might be a silly question, but could you confirm you've got the correct API key from https://readwise.io/access_token in your RR settings? Cheers, Mark

On Fri, May 19, 2023 at 4:53 AM Tomáš Baránek @.***> wrote:

Hi, it does not work for me... this is the console error message: >POST https://readwise.io/api/v2/highlights/ 400.

— Reply to this email directly, view it on GitHub https://github.com/mlava/send-readwise/issues/4#issuecomment-1553490317, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUKIPSVDQ26LTUJEQFAS4TXGZVZXANCNFSM6AAAAAAW7IKZVE . You are receiving this because you commented.Message ID: @.***>

tombarys commented 1 year ago

It is not silly, I understand well! Generated, copy-pasted again, you can see below. Even changed the name of the "book" to different to create a new one, but still the same error. What next to check?

CleanShot 2023-05-19 at 14 34 36@2x CleanShot 2023-05-19 at 14 36 07@2x

mlava commented 1 year ago

Thanks for your feedback here and on Twitter. PR submitted. https://github.com/Roam-Research/roam-depot/pull/682