mlavik1 / UnityVolumeRendering

Volume rendering, implemented in Unity3D. Want to support the project? Donate a small sum to Save The Children(https://www.savethechildren.net/) or another charity, and send me a message, and I will be greatly motivated!
https://fosstodon.org/@unityvolrend
MIT License
458 stars 127 forks source link

ShaderGraph Conversion #263

Open ChrisTsiamitas opened 3 months ago

ChrisTsiamitas commented 3 months ago

Are there any plans on converting the DirectVolumeRendering Shader to ShaderGraph shader? If not, how would you go and do it? Thank you in advance!

mlavik1 commented 2 months ago

Hi @ChrisTsiamitas , Good question! There are no plans to move the shaders to ShaderGraph. Personally I think it would be harder to work with visual shaders for volume rendering. I see a lot of benefit of using ShaderGraph for shaders that interact heavily with Unity's lighting system and depends on Unity-provided shader functionality, but that's not so much the case here. Also, I spend a lot of time profiling with tools like RenderDoc / Nvidia Nsight, so it's more practical to work in a shader language which is not so different form the final shader.

And regarding your second question: I'm not sure what would be the best way to convert it to ShaderGraph, but maybe someone else reading this will be able to give you some suggestions 🙏