mlavin / django-selectable

Tools and widgets for using/creating auto-complete selection widgets using Django and jQuery UI.
http://django-selectable.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
129 stars 64 forks source link

Finalize Release for Recent Django Support #186

Closed mlavin closed 7 years ago

mlavin commented 7 years ago

Currently there are a few errors tracking on 1.10 and 1.11. Master has deprecation problems as well but that's not a priority at the moment.

codecov-io commented 7 years ago

Codecov Report

Merging #186 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          14       14           
  Lines         459      459           
=======================================
  Hits          431      431           
  Misses         28       28
Impacted Files Coverage Δ
selectable/base.py 93.63% <100%> (+0.05%) :arrow_up:
selectable/templatetags/selectable_tags.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 766a2de...7530e58. Read the comment docs.

mlavin commented 7 years ago

Django 1.10 is passing but there seem to be some major problems with the new template based widget rendering in 1.11. That might have to wait for another day :(

mlavin commented 7 years ago

Allowing failures on Django 1.11 for now. Everything seems to be working now for Django 1.10 and the translation pieces are there.