Closed mlavin closed 6 years ago
Merging #190 into master will decrease coverage by
0.48%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 95.45% 94.97% -0.49%
==========================================
Files 10 10
Lines 374 378 +4
==========================================
+ Hits 357 359 +2
- Misses 17 19 +2
Impacted Files | Coverage Δ | |
---|---|---|
selectable/compat.py | 75% <100%> (+25%) |
:arrow_up: |
selectable/forms/fields.py | 92.94% <0%> (-2.36%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 494013a...1109eaa. Read the comment docs.
Hi @mlavin, looks like this and #194 do very similar things. I'd be happy to work on one or the other to try to get out a 2.0-compatible release. Any preference for a starting point? Also seems like we could drop some more older versions. Do you want to keep 1.8+, or only target 1.11+?
It's time to drop 1.8 support. This change addresses a few more places which need updates like the example project so I would start here.
Now that Django 1.11 support has landed this updates some of the code yielding deprecation warnings on Django 1.11. There is one that isn't addressed which is related to the new
renderer
argument for the widget class. This arg is only supported on 1.11 and it won't be deprecated until 2.1. It doesn't seem worth jumping through all of those hoops until 1.11 is the minimum supported version (which will probably be the release after this).