Closed vkurup closed 6 years ago
Merging #198 into master will decrease coverage by
0.48%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 95.45% 94.97% -0.49%
==========================================
Files 10 10
Lines 374 378 +4
==========================================
+ Hits 357 359 +2
- Misses 17 19 +2
Impacted Files | Coverage Δ | |
---|---|---|
selectable/compat.py | 75% <100%> (+25%) |
:arrow_up: |
selectable/forms/fields.py | 92.94% <0%> (-2.36%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 494013a...32b0be0. Read the comment docs.
Thanks for this update! Is there any reason to keep <1.11 support around? Seems like it can all just :fire:
awesome, I love deleting things!! I'll ping you when it's updated.
One thing I've found while testing this:
Django 2.0 no longer supports the user.is_authenticated()
method, this needs to be changed to a property (user.is_authenticated
).
That's a good point @kluchrj. I don't think that is caught by the test suite because of the heavy use of Mocks. That should also be addressed.
@vkurup, not sure if you're still working on this, but I've stripped out all the <1.11 compat and fixed the issue mentioned above in my fork: https://github.com/kluchrj/django-selectable/tree/deprecations
Should I submit a pull request to replace this one?
I have not had time to update this, so yes, please do submit a PR. Thanks!
Superceded by #199
This is mostly #190, with 1 commit added to add documentation and minor tox/travis configuration changes. There is one python warning remaining, which is probably best dealt with when we drop Django <1.11 support:
:crossed_fingers: that this works on Travis (not sure if deadsnakes will work?)