search

mlavin / sickmuse

Sick Muse is an open source web application for graphing Collectd RRD data.
BSD 2-Clause "Simplified" License
31 stars 7 forks source link

Bower fixes #18

Closed simonvanderveldt closed 7 years ago

simonvanderveldt commented 8 years ago

Hi @mlavin, thanks for this project! I just tried to get running from sources and ran into some minor issues. This PR fixes those.

The first commit adds underscore which was missing from the list of runtime dependencies. With this fix all dependencies are installed and running from sources works as it should.

The second commit renames component.json to bower.json because of this

You are using the deprecated component.json file

Also see https://twitter.com/hsablonniere/status/321510603011289088

simonvanderveldt commented 7 years ago

@mlavin ping! :) Can this PR be merged? If not I'll go ahead and close the PR, cleaning up my PR list :)

mlavin commented 7 years ago

Sorry! When I originally saw this I thought about just ripping out all of the Bower pieces since I feel like that's where the community was going (and one less thing for me to worry about breaking). But the time to do that just never appeared. Thank you for contributing this and let's go ahead and merge it. Still might one day remove Bower but in the meantime this resolves a real problem.

simonvanderveldt commented 7 years ago

@mlavin totally agree, but also didn't have the time to get rid of bower entirely :) Thx for the quick response/merge!