search

mlc-ai / relax

Apache License 2.0
137 stars 69 forks source link

Add support for Google Pixel OpenCL #282

Closed alex4o closed 11 months ago

alex4o commented 11 months ago

Google Pixel phones load the OpenCL symbols in a bit of a roundabout way. This is the way google does it in TensorFlow-lite. https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/delegates/gpu/cl/opencl_wrapper.cc#L75

Screenshot_20230809-231501.png

Screenshot_20230809-231758.png

junrushao commented 11 months ago

Thanks for this PR! This is amazing to see the OpenCL issue on Pixel gets fixed ❤️

BTW, do you want to instead submit PR to the mainline instead https://github.com/apache/tvm? We periodically sync with it and generally accept PRs there

MasterJH5574 commented 11 months ago

@alex4o Thanks for contribution! For another thing, could you please also fix the C++ format issue here https://ci.mlc.ai/blue/organizations/jenkins/mlc/detail/PR-282/1/pipeline?

alex4o commented 11 months ago

@junrushao I will make the PR against upstream later today, I just thought you might be more responsive and it will get merged faster.

@MasterJH5574 thanks for the tip, I will run clang-format in it.

MasterJH5574 commented 11 months ago

@alex4o Thanks! We can merge this one first for sure once the formatting is addressed.