mlc-ai / relax

Apache License 2.0
149 stars 75 forks source link

[Runtime] Add TVM_DLL to threading backend funcs #314

Closed MasterJH5574 closed 7 months ago

MasterJH5574 commented 7 months ago

This PR adds the TVM_DLL attribute to the functions in threading_backend.h to make it work with Windows packaging.

emliunix commented 7 months ago

Hi, I ran into the exact same issue when compiling mlc_llm on Windows w/ msvc. May I know why the PR is closed.

Nevermind, I found it in tvm repo: https://github.com/apache/tvm/pull/16630

MasterJH5574 commented 7 months ago

Thank you @emliunix! I'm going to rebase this repo onto apache/tvm soon to incorporate that change.