search

mlco2 / codecarbon

Track emissions from Compute and recommend ways to reduce their impact on the environment.
https://mlco2.github.io/codecarbon
MIT License
1.02k stars 158 forks source link

fixed trailing commas for 3.5, 3.6+ #353

Closed marksmayo closed 1 year ago

marksmayo commented 1 year ago

had to re-run black after to reformat as well, due to the commas

also pre-commit flake requires gitlab, which I don't have an account for, but I've run it manually as best I can

benoit-cty commented 1 year ago

Hello, thanks for your contribution. I don't understand why Black make so many changes as we already run Black in pre-commit. Does the default behavior changed ? Do you have an explanation ?

marksmayo commented 1 year ago

I'm not sure myself, I was wondering too. Maybe it's running against a different version of python / black? I'm on python 3.11

SaboniAmine commented 1 year ago

Hello, About pre-commit, the flake8 project have been moved to github recently, as Benoît kindly informed me. See this discussion. If needed, you can rebase this commit to your branch to have the correct configuration.

marksmayo commented 1 year ago

Hmm, conflicts and that query over black changing lots. I think I'll redo it instead. Hope that's ok

benoit-cty commented 1 year ago

Thank's, that's OK.