Add experiment_id to tracker-logged report

mlco2 / codecarbon

Track emissions from Compute and recommend ways to reduce their impact on the environment.

https://mlco2.github.io/codecarbon

MIT License

1.01k stars 158 forks source link

Add experiment_id to tracker-logged report #463

Closed halsimov closed 1 week ago

halsimov commented 8 months ago

Modify emissions_tracker.py & output.py to insert experiment_id field
Add experiment_id in tracker tests configs

Work on #387

benoit-cty commented 1 month ago

LGTM. Any remaining blocker @benoit-cty ?

I personally see no blocker but the tests are broken and there is conflict with Inigo refactoring of outputs.

SaboniAmine commented 1 month ago

Ok lets try to merge the logfire first integration, and consider again adding experiment id to tracker. We'll come back to this PR or the other one on the same topic.

inimaz commented 1 month ago

Hello @halsimov, thanks for this! In order to merge this there are minor conflicts. It is because the EmissionsData object has been moved here --> https://github.com/mlco2/codecarbon/blob/master/codecarbon/output_methods/emissions_data.py#L14 Could you move the experiment_id change there?

Thanks!

halsimov commented 2 days ago

Moved to #594