search

mlco2 / codecarbon

Track emissions from Compute and recommend ways to reduce their impact on the environment.
https://mlco2.github.io/codecarbon
MIT License
1.18k stars 177 forks source link

Fix CPU database compare #551

Closed benoit-cty closed 6 months ago

benoit-cty commented 6 months ago

In some case the fuzzy matching did not work on Intel CPU, this PR is fixing that, at least for "Intel(R) Xeon(R) Gold 6330N CPU @ 2.20Ghz" that was not matching "Intel Xeon Gold 6330N".

Will close #547

benoit-cty commented 6 months ago

Nice catch @benoit-cty ! Looks good to me.

Checking the test you changed, it is weird that it worked with Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (line 185) but did not work with Intel(R) Xeon(R) Gold 6330N CPU @ 2.20Ghz case. They look very similar.

Yes, I don't understand why it was failling.