Closed scap3yvt closed 2 months ago
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅
@hasan7n @aristizabal95 @VukW - do you have any idea why the MLCube deploy test is failing?
Hi @sarthakpati! this PR would have a lot of essential conflicts while merging with https://github.com/mlcommons/GaNDLF/pull/845 as all the scripts are refactored heavily while moving to new CLI API. How urgent are these fixes?
@VukW: I agree - this PR is not critical, and let's change this to get merged into #845 instead, since this is basically only about standardizing param names. Do you think you can help @scap3yvt with this?
IMO, same goes for #852 - thoughts?
@sarthakpati yes, sure, I can help, though not sure how exactly
But it seems to me that it may be easier to start a new branch based on https://github.com/mlcommons/GaNDLF/pull/845 rather than merge conflicts. @scap3yvt what do you think? Can you take #845 as base and add fixes & improvements over it? Or do you need my help for it? If any, feel free to ping me, let's solve this together
@sarthakpati concerning #852 - that PR is not meant to be merged, I use it for testing & debugging MLCube CI test that behave in strange way for me
This has been superseded by #853
Fixes #849
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].