mlcommons / GaNDLF

A generalizable application framework for segmentation, regression, and classification using PyTorch
https://gandlf.org
Apache License 2.0
158 stars 79 forks source link

Add a new optimizer #874

Closed pranayasinghcsmpl closed 4 months ago

pranayasinghcsmpl commented 4 months ago

Fixes #869

Proposed Changes

Checklist

github-actions[bot] commented 4 months ago

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
:x: @pranayasinghcsmpl
You can retrigger this bot by commenting recheck in this Pull Request

pranayasinghcsmpl commented 4 months ago

@sarthakpati While linting (using black .) i am getting the following error:

error: cannot format D:\Workspace\gandlf\fork\GaNDLF\testing\entrypoints__init__.py: Cannot parse: 321:26: ) as e, Oh no! 💥 💔 💥 170 files left unchanged, 1 file failed to reformat

sarthakpati commented 4 months ago

@sarthakpati While linting (using black .) i am getting the following error:

error: cannot format D:\Workspace\gandlf\fork\GaNDLF\testing\entrypointsinit.py: Cannot parse: 321:26: ) as e, Oh no! 💥 💔 💥 170 files left unchanged, 1 file failed to reformat

@VukW or @szmazurek could you perhaps check this?

szmazurek commented 4 months ago

Hey there! I took a look and actually, I failed to replicate the error you are seeing @pranayasinghcsmpl, are you sure there were no syntax errors in your local code when you were running it? Also maybe try to call black -v . flag to see the output verbose. The rest of the failed black tests were due to unformatted files present, I have done the formatting and pushed changes, and now the black test is passing. Probably due to this failure the black did not format those other files and that's why the CI failed.

pranayasinghcsmpl commented 4 months ago

Thanks @szmazurek