Closed pranayasinghcsmpl closed 4 months ago
MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
:x: @pranayasinghcsmpl
You can retrigger this bot by commenting recheck in this Pull Request
@sarthakpati While linting (using black .) i am getting the following error:
error: cannot format D:\Workspace\gandlf\fork\GaNDLF\testing\entrypoints__init__.py: Cannot parse: 321:26: ) as e, Oh no! 💥 💔 💥 170 files left unchanged, 1 file failed to reformat
@sarthakpati While linting (using black .) i am getting the following error:
error: cannot format D:\Workspace\gandlf\fork\GaNDLF\testing\entrypointsinit.py: Cannot parse: 321:26: ) as e, Oh no! 💥 💔 💥 170 files left unchanged, 1 file failed to reformat
@VukW or @szmazurek could you perhaps check this?
Hey there! I took a look and actually, I failed to replicate the error you are seeing @pranayasinghcsmpl, are you sure there were no syntax errors in your local code when you were running it? Also maybe try to call black -v .
flag to see the output verbose. The rest of the failed black tests were due to unformatted files present, I have done the formatting and pushed changes, and now the black test is passing. Probably due to this failure the black did not format those other files and that's why the CI failed.
Thanks @szmazurek
Fixes #869
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].