Open pranayasinghcsmpl opened 1 month ago
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅
Thanks for the PR! I have changed the base to the "new-apis" branch (instead of master
), and some conflicts need to be resolved. can you take a look?
Waiting to hear from @NielsRogge about this PR. Also, is there any way to put unit tests for this?
2 points from me:
setup.py
.@sarthakpati, Sure I'll start working on the tests. Also I'll add the dependencies in the next commit.
The mlcube-docker errors in actions are related to https://github.com/mlcommons/mlcube/issues/360
Changing the pip version in the workflow should help - please put this change in a separate PR, @pranayasinghcsmpl
Edit: done in #887
@pranayasinghcsmpl - the latest changes from the base branch should make things easier. However, we are still missing updates to setup.py
.
Fixes #727
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].