mlcommons / GaNDLF

A generalizable application framework for segmentation, regression, and classification using PyTorch
https://gandlf.org
Apache License 2.0
150 stars 78 forks source link

Added huggingface integration - DEPRECATED #880

Open pranayasinghcsmpl opened 1 month ago

pranayasinghcsmpl commented 1 month ago

Fixes #727

Proposed Changes

Checklist

github-actions[bot] commented 1 month ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

sarthakpati commented 1 month ago

Thanks for the PR! I have changed the base to the "new-apis" branch (instead of master), and some conflicts need to be resolved. can you take a look?

image

sarthakpati commented 1 month ago

Waiting to hear from @NielsRogge about this PR. Also, is there any way to put unit tests for this?

sarthakpati commented 1 month ago

2 points from me:

  1. Tests need to be added. See the entrypoint tests here.
  2. I am guessing hf needs to be added as a dependency to setup.py.
pranayasinghcsmpl commented 1 month ago

@sarthakpati, Sure I'll start working on the tests. Also I'll add the dependencies in the next commit.

sarthakpati commented 3 weeks ago

The mlcube-docker errors in actions are related to https://github.com/mlcommons/mlcube/issues/360

Changing the pip version in the workflow should help - please put this change in a separate PR, @pranayasinghcsmpl

Edit: done in #887

sarthakpati commented 2 weeks ago

@pranayasinghcsmpl - the latest changes from the base branch should make things easier. However, we are still missing updates to setup.py.