Adding function to get augmentation transforms

szmazurek commented 3 weeks ago

Fixes #888

Proposed Changes

function for getting the augmentation transforms from params dict
using that function in dataset constructor

Checklist

[X] CONTRIBUTING guide has been followed.
[X] PR is based on the current GaNDLF master .
[X] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
[X] Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
[X] Code has been blacked for style consistency and linting.
[X] If applicable, version information has been updated in GANDLF/version.py.
[ ] If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
[X] Usage documentation has been updated, if appropriate.
[ ] Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
[ ] If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

github-actions[bot] commented 3 weeks ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

sarthakpati commented 3 weeks ago

Please change the base to https://github.com/mlcommons/GaNDLF/tree/new-apis_v0.1.0-dev

szmazurek commented 3 weeks ago

Member

Done, not sure if we should re-run the tests somehow

VukW commented 3 weeks ago

Hi! Folks, by some strange reason this PR didn't trigger CI tests at all. However, it brought a bug (failing test) inside base branch, that failed in a neighbor PR: https://github.com/mlcommons/GaNDLF/actions/runs/9724955407/job/26841721449?pr=890 I'm not sure if it's the only failure. @szmazurek can you plz run the tests locally to check if everything behaves as you expected in the PR?

szmazurek commented 3 weeks ago

@VukW on it!

sarthakpati commented 2 weeks ago

@szmazurek are you looking into the error? Starting to see this pop up for other PRs as well.

VukW commented 2 weeks ago

Checking fix here: https://github.com/mlcommons/GaNDLF/pull/890/commits/c312e24ce99540f081c38e72922113cb73b06c57 https://github.com/mlcommons/GaNDLF/pull/890

sarthakpati commented 2 weeks ago

Checking fix here: c312e24 #890

Thanks, @VukW!

I am guessing that fixed it, because at least one of the tests that was breaking before is now functional.

VukW commented 2 weeks ago

+, all tests are running successfully now. Merged the fix together with #890 .

szmazurek commented 2 weeks ago

Hey guys, I had a chance to look at that closely just now, but I see @VukW already fixed that - thanks!

mlcommons / GaNDLF

Adding function to get augmentation transforms #889

Proposed Changes

Checklist