Cleaning setup - Githubissues

mlcommons / GaNDLF

A generalizable application framework for segmentation, regression, and classification using PyTorch

https://gandlf.org

Apache License 2.0

150 stars 78 forks source link

Cleaning setup #890

Closed VukW closed 2 weeks ago

VukW commented 3 weeks ago

Proposed Changes

Right now setup.py places some GANDLF repo files to site-packages/ of the user's python env. This cleaning helps to keep all gandlf files in site-packages/GANDLF so keeping user env tidy + removes other unused parts of setup.py
Fix for #889

github-actions[bot] commented 3 weeks ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

VukW commented 3 weeks ago

Hi! Concerning pytest failure - the failed test is actually brought by https://github.com/mlcommons/GaNDLF/pull/889/ - new augmentations. Let's proceed there, restored branch & PR

Concerning linter issues - I'll fix it in this PR

szmazurek commented 3 weeks ago

Hey! I agree with your approach @VukW for the setup file. Regarding the augmentations - interesting thing, I did not receive any errors during tests for this pr. Will also take a look, if you find some cause of that earlier please let me know.

sarthakpati commented 3 weeks ago

Thanks, folks!