Closed scap3yvt closed 1 month ago
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅
This seems to be okay for me. Any comments, @VukW and @brandon-edwards?
This looks reasonable to me as well, but I have not tested it.
This should not be merged until #947 is merged and the master gets tagged.
Support ticket generated with Codacy to explore the coverage issue.
Fixes #944
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logging
library is being used and noprint
statements are left.