Inform submission about evaluation step

mlcommons / algorithmic-efficiency

MLCommons Algorithmic Efficiency is a benchmark and competition measuring neural network training speedups due to algorithmic improvements in both training algorithms and models.

https://mlcommons.org/en/groups/research-algorithms/

Apache License 2.0

321 stars 62 forks source link

Inform submission about evaluation step #720

Closed Niccolo-Ajroldi closed 5 months ago

Niccolo-Ajroldi commented 5 months ago

Inform the submission if an evaluation is going to happen at the current step or not.

Modifications:

moved evaluation decision before update_params
added is_eval_step argument to update_params
modified all submissions to include is_eval_step

github-actions[bot] commented 5 months ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

fsschneider commented 5 months ago

I think we can close this PR judging from the WG meeting summarized in #719 (especially https://github.com/mlcommons/algorithmic-efficiency/issues/719#issuecomment-2027805925).