search

mlcommons / chakra

Repository for MLCommons Chakra schema and tools
https://mlcommons.org/working-groups/research/chakra/
Apache License 2.0
45 stars 17 forks source link

Unit tests et feeder #72

Closed AlexandruAntonescuKeysight closed 4 days ago

AlexandruAntonescuKeysight commented 1 month ago

Summary

This PR adds unit tests for ETFeeder and also a workflow for building and running these tests. The tests were implemented using Google Test Framework. The workflow contains 4 steps:

Test Plan

The input for the tests are 2 ETs, which were placed in the tests/data directory. There are 10 tests which focus on ETfeeder Class.

github-actions[bot] commented 1 month ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

TaekyungHeo commented 1 month ago

The code looks good to me. I appreciate it, @AlexandruAntonescuKeysight. This is an essential change. However, I have one concern regarding how we add files to the repository. Adding approximately 34MB of files directly to the repository seems too heavy to me. The first option we should consider is to tar and gzip these files. Another option is to upload them to GitHub LFS. I believe we need further discussion on this with @srinivas212 and @tushar-krishna.

AlexandruAntonescuKeysight commented 2 weeks ago

The code looks good to me. I appreciate it, @AlexandruAntonescuKeysight. This is an essential change. However, I have one concern regarding how we add files to the repository. Adding approximately 34MB of files directly to the repository seems too heavy to me. The first option we should consider is to tar and gzip these files. Another option is to upload them to GitHub LFS. I believe we need further discussion on this with @srinivas212 and @tushar-krishna.

I've replaced those traces with a tar.gz containing just one small trace, now the size has been reduced significantly.