search

mlcommons / inference_policies

Issues related to MLPerf™ Inference policies, including rules and suggested changes
https://mlcommons.org/en/groups/inference/
Apache License 2.0
55 stars 52 forks source link

LLM Benchmark Decoding Algorithm Rules Proposal. #278

Closed yyetim closed 1 year ago

github-actions[bot] commented 1 year ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

yyetim commented 1 year ago

Thanks, I incorporated the changes from the LLM task force meeting, and also from the comments in the PR. PTAL.

We discussed in the task force meeting that Bhadri and Thomas were going to add more details to the beam search reference in the GPT-J. I added a TODO for them.

nv-ananjappa commented 1 year ago

@yyetim Could you sign the MLCommons CLA so that this PR can be merged? CC: @mrasquinha-g

yyetim commented 1 year ago

Will do by tomorrow

On Mon, Jul 17, 2023, 11:53 PM Ashwin Nanjappa @.***> wrote:

@yyetim https://github.com/yyetim Could you sign the MLCommons CLA so that this PR can be merged? CC: @mrasquinha-g https://github.com/mrasquinha-g

— Reply to this email directly, view it on GitHub https://github.com/mlcommons/inference_policies/pull/278#issuecomment-1638865671, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQZQU5WZTM2IC2KNFR7E3XQWQ3RANCNFSM6AAAAAAZZKINNQ . You are receiving this because you were mentioned.Message ID: @.***>

yyetim commented 1 year ago

I submitted the form for the MLCommons CLA, @mrasquinha-g can you help with approval?

yyetim commented 1 year ago

Requested access and added the google email used in the commit to my account. Will retry a dummy commit to rerun the check.

yyetim commented 1 year ago

OK, the cla-bot check now passed. @mrasquinha-g can you approve again to merge? Thanks