search

mlcommons / inference_policies

Issues related to MLPerf™ Inference policies, including rules and suggested changes
https://mlcommons.org/en/groups/inference/
Apache License 2.0
55 stars 52 forks source link

Is Ethernet point-to-point allowed in Network division of 3.1? #279

Closed nv-ananjappa closed 1 year ago

nv-ananjappa commented 1 year ago

@psyhtest asked in today's WGM: "From our discussions I recall that point-to-point Ethernet connections (without a switch in the middle) are allowed [in Network division submissions]; however, the rules are not entirely clear on this subject."

@liorkhe confirmed that point-to-point Ethernet is allowed, but wanted @DilipSequeira to confirm since they both were instrumental in the creation of the Network division rules.

@DilipSequeira has confirmed offline that @liorkhe is right: "the [permitted] fabric has to have switching capability, but that’s not the same as requiring the submission itself to have a switch." But also "it might be best to have separate sections for the fabric requirements and the system topology requirements since those are mixed together right now and cause confusion."

nv-ananjappa commented 1 year ago

@liorkhe Can I volunteer you to submit a PR clarifying the Network division rules better as suggested above?

liorkhe commented 1 year ago

@nv-ananjappa I think the text is OK when reading the rules as a whole section. I modified actually in another place to clarify. can you please check if this text change is OK. If so, I will create a pull request. https://github.com/liorkhe/inference_policies/pull/8/files

liorkhe commented 1 year ago

@nv-ananjappa, @psyhtest can we conclude this one? Is it OK to submit this PR?

liorkhe commented 1 year ago

thanks for the review. the PR for MLcommons rules is at: https://github.com/mlcommons/inference_policies/pull/280

psyhtest commented 1 year ago

Closed by merging #280.