mlcommons / logging

MLPerf™ logging library
https://mlcommons.org/en/groups/best-practices-benchmark-infra
Apache License 2.0
30 stars 45 forks source link

Fix run stop check #339

Closed maanug-nv closed 1 year ago

maanug-nv commented 1 year ago

Existing check will pass on lines such as:

:::MLLOG {"namespace": "", "time_ms": 1684006089927, "event_type": "POINT_IN_TIME", "key": "eval_accuracy", "value": {0}, "metadata": {"file": "check_run_stop.py", "lineno": 411, "epoch_num": 16}}

This is line contains 'run_stop' string, but this is not a run_stop event, in which case 'run_stop' is the key.

github-actions[bot] commented 1 year ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

maanug-nv commented 1 year ago

@pgmpablo157321 fyi. We can discuss this tomorrow.

cc @ShriyaPalsamudram