mlcommons / mobile_app_open

Mobile App Open
https://mlcommons.org/en/groups/inference-mobile/
Apache License 2.0
43 stars 21 forks source link

Submit 4.0-based app to Apple App Store #780

Open freedomtan opened 1 year ago

freedomtan commented 1 year ago

Let's check what need to be done before submitting to App Store

And then submit it.

freedomtan commented 1 year ago

ask @nathanw-mlc for the App Store account

nathanw-mlc commented 1 year ago

Anh already has access to the App Store accounts. Will anyone else need access?

RSMNYS commented 1 year ago

Hi guys! We need screenshots with such sizes:

Screenshot 2023-09-13 at 14 39 06

Based on this: https://developer.apple.com/help/app-store-connect/reference/screenshot-specifications

6.5":

iPhone 14 Plus iPhone 13 Pro Max iPhone 12 Pro Max iPhone 11 Pro Max iPhone 11 iPhone XS Max iPhone XR

5.5":

iPhone 8 Plus iPhone 7 Plus iPhone 6s Plus

Unfortunately we can't make the screenshots from the simulators as it has Debug label on the screen, and such screenshots are not acceptable. So we need to find these devices to prepare the screenshots for the submission.

RSMNYS commented 1 year ago

Actually it's possible to remove that label for the debug flutter mode. Simulator Screenshot - iPhone 14 Pro Max - 2023-09-13 at 15 00 42

Let me know if I should prepare all screenshots and upload to the App Store. My email is: Sergij.r@scopicsoftware.com.

anhappdev commented 1 year ago

Anh already has access to the App Store accounts. Will anyone else need access?

@nathanw-mlc Please assign @RSMNYS a role so he can prepare the app for the App Store release. Thank you.

nathanw-mlc commented 1 year ago

@RSMNYS What Apple ID email address should I use to grant you access to the App Store? If you don't want to post it publicly in this thread, you can email systems@mlcommons.org.

RSMNYS commented 1 year ago

Sergij.r@scopicsoftware.com. Thank you

nathanw-mlc commented 1 year ago

Thanks, invitation sent.

RSMNYS commented 1 year ago

@RSMNYS What Apple ID email address should I use to grant you access to the App Store? If you don't want to post it publicly in this thread, you can email systems@mlcommons.org.

@nathanw-mlc please change my role to the app manager, with the developer role I'm not able to upload the screenshots.

Thanks

nathanw-mlc commented 1 year ago

@RSMNYS, I've updated your role as requested.

RSMNYS commented 1 year ago
Screenshot 2023-09-18 at 21 42 30 Screenshot 2023-09-18 at 21 42 49
nathanw-mlc commented 1 year ago

Do we want screenshots with the blue background of the official release, since presumably that's what people will be downloading? If you need, I can provide them.

anhappdev commented 1 year ago

https://developer.apple.com/app-store/app-privacy-details/

freedomtan commented 1 year ago

@TheKanter and @peladodigital

freedomtan commented 11 months ago

@Mostelk let's try to discuss the privacy policy statement issue in the working group policy meeting.

freedomtan commented 11 months ago
iphone 15 Pro Max iPhone 14 Pro iPhone 13
freedomtan commented 11 months ago

An example result.json file on iPhone 13.

Currently, besides benchmark numbers, what we collected in the app are:

{
  ...,
  "environment_info": {
    "platform": "ios",
    "value": {
      "android": null,
      "ios": {
        "os_version": "Version 17.0.1 (Build 21A340)",
        "model_code": "iPhone14,5",
        "model_name": "iPhone 13",
        "soc_name": "Apple A15"
      },
      "windows": null
    }
  },
  "build_info": {
    "version": "3.1.0",
    "build_number": "1",
    "build_date": "2023-09-22T16:56:43.134131",
    "official_release_flag": false,
    "dev_test_flag": false,
    "backend_list": [
      "libcoremlbackend",
      "libtflitebackend"
    ],
    "git_branch": "ndk_25_quick_hack",
    "git_commit": "73942b6a1a725972d6f9f6390dd4315f9c663a0b",
    "git_dirty_flag": true
  }
}
peladodigital commented 11 months ago

@RSMNYS Please go ahead with these for the configuration of the store. We can go with this and then later add if needed

RSMNYS commented 10 months ago

@RSMNYS Please go ahead with these for the configuration of the store. We can go with this and then later add if needed

@peladodigital I think you've missed the original request. Let me share it again. To submit the app to the store we need to check and fill the next points:

@peladodigital can you help with this please?

Here is the link to the app store: https://appstoreconnect.apple.com/apps/1629525778/appstore/privacy

freedomtan commented 10 months ago

@TheKanter and @peladodigital Please help provide the privacy policy statement, c.f. https://developer.apple.com/app-store/app-privacy-details/.

@RSMNYS please pick one from TestFlight.

TheKanter commented 10 months ago

I'm working to get one generated for us. Do you have any examples I can share with our attorneys? Ideally a simple one.

On Mon, Nov 13, 2023 at 10:32 PM Koan-Sin Tan @.***> wrote:

@TheKanter https://github.com/TheKanter and @peladodigital https://github.com/peladodigital Please help provide the privacy policy statement, c.f. https://developer.apple.com/app-store/app-privacy-details/ .

@RSMNYS https://github.com/RSMNYS please pick one from TestFlight.

— Reply to this email directly, view it on GitHub https://github.com/mlcommons/mobile_app_open/issues/780#issuecomment-1809620950, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXLOK724PI4ODE3ONFH2OLYEMGABAVCNFSM6AAAAAA4UI3C5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGYZDAOJVGA . You are receiving this because you were mentioned.Message ID: @.***>

anhappdev commented 10 months ago

I'm working to get one generated for us. Do you have any examples I can share with our attorneys? Ideally a simple one.

@TheKanter You may use one of the templates from: https://termly.io/products/privacy-policy-generator/

freedomtan commented 10 months ago

maybe we need both "terms of use" / "EULA" and "privacy policy"

TheKanter commented 10 months ago

In on it with our lawyers.

On Mon, Nov 20, 2023 at 10:38 PM Koan-Sin Tan @.***> wrote:

maybe we need both "terms of use" / "EULA" and "privacy policy"

— Reply to this email directly, view it on GitHub https://github.com/mlcommons/mobile_app_open/issues/780#issuecomment-1820323136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXLOK7F5QO6TYOFDO2JEDDYFRD6JAVCNFSM6AAAAAA4UI3C5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGMZDGMJTGY . You are receiving this because you were mentioned.Message ID: @.***>

freedomtan commented 9 months ago

@RSMNYS and @anhappdev can we submit the iOS app to mac app store? Or we need native macOS UI?

anhappdev commented 9 months ago

@RSMNYS and @anhappdev can we submit the iOS app to mac app store? Or we need native macOS UI?

Yes, we can but the app will work only on Mac computers with Apple silicon (M1, M2, ...) https://support.apple.com/en-vn/guide/app-store/fird2c7092da/mac

TheKanter commented 9 months ago

That’s fine to only test Apple silicon. We also should have TOU and privacy policy soon.

On Mon, Nov 27, 2023 at 9:58 PM Anh @.***> wrote:

@RSMNYS https://github.com/RSMNYS and @anhappdev https://github.com/anhappdev can we submit the iOS app to mac app store? Or we need native macOS UI?

Yes, we can but the app will work only on Mac computers with Apple silicon (M1, M2, ...) https://support.apple.com/en-vn/guide/app-store/fird2c7092da/mac

— Reply to this email directly, view it on GitHub https://github.com/mlcommons/mobile_app_open/issues/780#issuecomment-1829163316, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXLOK22PXBMQZYEBFVH4R3YGV4PXAVCNFSM6AAAAAA4UI3C5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGE3DGMZRGY . You are receiving this because you were mentioned.Message ID: @.***>

freedomtan commented 9 months ago

Let's enable macOS compatibility for TestFlight, then we can test the app on both iOS and macOS (apple silicon machines)

TheKanter commented 9 months ago

I have a MacBook Air we can use!

On Mon, Nov 27, 2023 at 10:23 PM Koan-Sin Tan @.***> wrote:

Let's enable macOS compatibility for TestFlight, then we can test the app on both iOS and macOS (apple silicon machines)

— Reply to this email directly, view it on GitHub https://github.com/mlcommons/mobile_app_open/issues/780#issuecomment-1829191379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXLOKY4UGOFX42LHJALJBLYGV7MJAVCNFSM6AAAAAA4UI3C5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGE4TCMZXHE . You are receiving this because you were mentioned.Message ID: @.***>

anhappdev commented 9 months ago

The app should be already available on TestFlight for Mac (https://apps.apple.com/us/app/testflight/id899247664)

freedomtan commented 9 months ago

@@RSMNYS please check if you got the term of use and privacy policy docs. If yes, let's try to make this into the app store.

@freedomtan to check if those docs are available to @RSMNYS and @anhappdev.

freedomtan commented 9 months ago

open source: TensorFlow: include TensorFlow's apache license models: apache license should be enough

@freedomtan to crease an issue to track this and check open source third-party libraries we used. Check other benchmark programs.


vendor spec (for Android):

anhappdev commented 3 months ago

@RSMNYS Since we have a new design for v4.0, can you please update the screenshots in the App Store Connect?

RSMNYS commented 3 months ago

@anhappdev are those screenshots correct? I'm using the v4.0 branch, official_build, but see a bunch of UI issues as below. Where we use black text on blue background, and other components also looks wrong and visibility is bad. Please let me know.

Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 10 52

Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 05 40 Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 05 45 Simulator Screenshot - iPhone 15 Pro Max - 2024-05-31 at 18 15 46

anhappdev commented 3 months ago

@anhappdev are those screenshots correct? I'm using the v4.0 branch, official_build, but see a bunch of UI issues as below. Where we use black text on blue background, and other components also looks wrong and visibility is bad. Please let me know.

I am not sure why your build looks different, maybe you used a different Flutter SDK version? For iOS, can you use the version 4.0 (build 125) from TestFlight? The UI looks correct on my iPhone with the build from TestFlight.

RSMNYS commented 3 months ago

You're right @anhappdev. Now have everything looks good. By the way, we can use the fvm to manage the flutters versions, and lock the flutter version for the project. So everyone can use the same version of the flutter sdk. What do you think?

anhappdev commented 3 months ago

You're right @anhappdev. Now have everything looks good. By the way, we can use the fvm to manage the flutters versions, and lock the flutter version for the project. So everyone can use the same version of the flutter sdk. What do you think?

We have already defined the Flutter SDK version in the pubspec.yml file. And we don't change the Flutter SDK version often, so I am not sure if we need yet another tool.

anhappdev commented 3 months ago

@RSMNYS Please also upload screenshots for iPad.

The items below are required to start the review process: You must upload a screenshot for 12.9-inch iPad Pro (2nd generation) displays. You must upload a screenshot for 13-inch iPad displays.

anhappdev commented 3 months ago

@nathanw-mlc Can you help resolve this one?

The items below are required to start the review process: Under the Digital Services Act, you must provide and verify information regarding your account. Learn More

RSMNYS commented 3 months ago

@RSMNYS Please also upload screenshots for iPad.

The items below are required to start the review process: You must upload a screenshot for 12.9-inch iPad Pro (2nd generation) displays. You must upload a screenshot for 13-inch iPad displays.

done