mlcommons / mobile_app_open

Mobile App Open
https://mlcommons.org/en/groups/inference-mobile/
Apache License 2.0
38 stars 19 forks source link

fix: performance drop caused by UI animation #857

Closed anhappdev closed 3 months ago

anhappdev commented 3 months ago

The progress screen now looks like this and has no animation:


2024-02-22:

github-actions[bot] commented 3 months ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

mohitmundhragithub commented 3 months ago

Thanks a lot. We experimented with these settings. 1) "No animation" gives the best performance. 2) "dotted circle" gives performance as good as the previous UI. 3) "gradient circle" gives performance quite a bit less than previous UI.

user experience wise, all the three options looks ok to us.

anhappdev commented 3 months ago

@mohitmundhragithub Thanks for the feedback. BTW, I forgot to mention, if you don't use the release APKs from GitHub but build the app locally, please make sure you run it with the --profile flag flutter run --profile when testing performance.

mohitmundhragithub commented 3 months ago

@mohitmundhragithub Thanks for the feedback. BTW, I forgot to mention, if you don't use the release APKs from GitHub but build the app locally, please make sure you run it with the --profile flag flutter run --profile when testing performance.

which portion will it enable?

freedomtan commented 3 months ago

no animation, but when the go button pressed, make the outer circle bright.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

mohitmundhragithub commented 3 months ago

This PR may be required to be cherry-picked to submission-v4.0 branch as well.