Closed bkorycki closed 2 weeks ago
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅
Not sure how hard this would be, but what I was hoping for with --machine-reports was no progress bar, the JSONL progress update, and either regular logging or structlog-style JSONL logging.
Okay I made quite a few changes @wpietri @dhosterman
--machine-reports
to --json-logs
--json-logs
echo
instead of logging.info
. I originally switching over to logging in the first progress reports PR in order to handle different log levels for machine vs. human callers. This is not relevant now that log statements always need to be printed. Also logging.info
did not print to stdout in parallel mode.I just tested this against the latest changes in modellab and it works great! It's still showing progress bars for the dependency downloads, but that'll require downstream work in modelgauge to fix and doesn't impede using the progress data provided.
Output with
--machine-reports --parallel true
flags from before:After this change:
Let me know if this is what we want.