search

mlcommons / modelgauge

Make it easy to automatically and uniformly measure the behavior of many AI Systems.
https://mlcommons.org/ai-safety/
Apache License 2.0
26 stars 7 forks source link

mypy is complaining about untyped imports #558

Closed rogthefrog closed 2 months ago

rogthefrog commented 2 months ago

We don't want to disable checks for untyped imports project-wide, I think. The way to achieve that is to use the # type: ignore comment (the way Barbara had it), but a round of linting and black formatting reformatted the private annotator import lines. That moved the type ignore comment to the end of the parsed line, rather than the end of the "physical" line in the file, and mypy doesn't understand the comment if it's there.

:(

github-actions[bot] commented 2 months ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅