search

mlcommons / power-dev

Dev repo for power measurement for the MLPerf™ benchmarks
https://mlcommons.org/en/groups/best-practices-power
Apache License 2.0
16 stars 22 forks source link

Add version 1.10.0 to submission checker #286

Closed pgmpablo157321 closed 1 year ago

pgmpablo157321 commented 1 year ago

Fix #285

github-actions[bot] commented 1 year ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

arjunsuresh commented 1 year ago

Thank you @pgmpablo157321 for the change. But I guess the power WG wanted to remove support for 1.9.x. @s-idgunji am I correct? This line also needs an update.

s-idgunji commented 1 year ago

Yes – we worked early to get 1.10.0 in, and it has been tested to be consistent. We should only support 1.10.0 since SPEC has fixed bugs in PTD and recommended that supersede past versions.

Thanks Arjun.

From: Arjun Suresh @.> Sent: Wednesday, February 8, 2023 10:17 AM To: mlcommons/power-dev @.> Cc: Sachin Idgunji @.>; Mention @.> Subject: Re: [mlcommons/power-dev] Add version 1.10.0 to submission checker (PR #286)

Thank you @pgmpablo157321https://github.com/pgmpablo157321 for the change. But I guess the power WG wanted to remove support for 1.9.x. @s-idgunjihttps://github.com/s-idgunji am I correct? This linehttps://github.com/mlcommons/power-dev/blob/master/compliance/check.py#L198 also needs an update.

— Reply to this email directly, view it on GitHubhttps://github.com/mlcommons/power-dev/pull/286#issuecomment-1423048391, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANARCVIQNIZH7YL55BBKNOLWWPPKFANCNFSM6AAAAAAUVRWPJA. You are receiving this because you were mentioned.Message ID: @.**@.>>

pgmpablo157321 commented 1 year ago

@s-idgunji Can you review and merge this PR?

s-idgunji commented 1 year ago

I’ll do it now.

From: Pablo Gonzalez @.> Sent: Thursday, February 9, 2023 3:58 PM To: mlcommons/power-dev @.> Cc: Sachin Idgunji @.>; Mention @.> Subject: Re: [mlcommons/power-dev] Add version 1.10.0 to submission checker (PR #286)

@s-idgunjihttps://github.com/s-idgunji Can you review and merge this PR?

— Reply to this email directly, view it on GitHubhttps://github.com/mlcommons/power-dev/pull/286#issuecomment-1424993183, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANARCVN44DXRMCGZXKYSCFDWWWABVANCNFSM6AAAAAAUVRWPJA. You are receiving this because you were mentioned.Message ID: @.**@.>>