search

mlcommons / training

Reference implementations of MLPerf™ training benchmarks
https://mlcommons.org/en/groups/training
Apache License 2.0
1.61k stars 555 forks source link

[SSD] Update logging to v0.7 #414

Closed ahmadki closed 3 years ago

ahmadki commented 4 years ago

This PR is based on https://github.com/mlperf/training/pull/367 but fixes syntax errors and adds missing keys

googlebot commented 4 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ahmadki commented 4 years ago

@gsrujana89 , As this work builds on top of #367, can you sign the CLA to unblock the PR. Thank you

johntran-nv commented 4 years ago

Hi @christ1ne , could you please have @gsrujana89 sign the CLA so we can get this PR merged?

christ1ne commented 4 years ago

ok

gsrujana89 commented 4 years ago

@googlebot I consent

matthew-frank commented 4 years ago

@googlebot I consent

matthew-frank commented 4 years ago

@googlebot I consent.

ahmadki commented 4 years ago

@googlebot I consent.

ahmadki commented 4 years ago

@googlebot I fixed it.

christ1ne commented 4 years ago

To resolve this CLA issue, I suggest @ahmadki open a new PR with the same code change, and close this one. Much faster that way.

matthew-frank commented 4 years ago

@googlebot I consent.

matthew-frank commented 4 years ago

@googlebot I consent.

google-cla[bot] commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.