Fix links to BERT input files

mlcommons / training

Reference implementations of MLPerf™ training benchmarks

https://mlcommons.org/en/groups/training

Apache License 2.0

1.58k stars 549 forks source link

Fix links to BERT input files #463

Closed johntran-nv closed 3 years ago

johntran-nv commented 3 years ago

Fix issue 462 - missing BERT input files.

github-actions[bot] commented 3 years ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

johntran-nv commented 3 years ago

Hi @bitfort , could we get a quick approval here? Just fixing up links, so nothing contentious.

petermattson commented 3 years ago

I'm OK with this if sgpyc is OK. Yuechao?

petermattson commented 3 years ago

(I'm removing myself as reviewer leaving only Yuechao.)

sgpyc commented 3 years ago

The new links work and the changes look good to me. BTW, the v0.7 dataset generation steps (which this PR is fixing) is not deterministic. Changes in PR451 tries to make the dataset deterministic, by providing the dataset right before samples duplication and mask generation.

johntran-nv commented 3 years ago

@petermattson , we need a review from someone with write access, other than me. Could you please approve now that Yuechao has approved?