search

mlcommons / training

Reference implementations of MLPerf™ training benchmarks
https://mlcommons.org/en/groups/training
Apache License 2.0
1.6k stars 553 forks source link

Contributing.md is out of date #481

Closed TheKanter closed 1 year ago

TheKanter commented 3 years ago

It refers to the old google CLA, etc. with bad links. We need to update with links to our newer system for CLAs, etc.

This is probably a problem for all our repos :(

petermattson commented 3 years ago

Chatted with system folks. Subin was kind enough to produce a new contributing.md and Guenther will be rolling out soon.

johntran-nv commented 1 year ago

I believe this was deployed a long time ago. Can we close this issue?

TheKanter commented 1 year ago

Does https://mlcommons.org/en/credits/ reflect all current and past training benchmarks, datasets, etc.?

David

On Tue, Nov 8, 2022 at 10:02 AM johntran-nv @.***> wrote:

I believe this was deployed a long time ago. Can we close this issue?

— Reply to this email directly, view it on GitHub https://github.com/mlcommons/training/issues/481#issuecomment-1307621116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXLOK45CSODTAD5UKL362LWHKIRTANCNFSM442TCHJA . You are receiving this because you authored the thread.Message ID: @.***>

johntran-nv commented 1 year ago

What's the difference between that credits page and the google sheet we used to track?

Anyway, this PR was about the contributing.md document which explained how to contribute to the repos, which is orthogonal to the credits, right?

TheKanter commented 1 year ago

Great question. Credits page https://mlcommons.org/en/credits/ is externally facing. The spreadsheet https://docs.google.com/spreadsheets/d/17q_OtvVI_C5ET0shUTObHwiplUVRj5gFkU1dTkU7AcQ/edit#gid=0 contains the content that we will put in the externally facing page.

And yes, it appears that I put this in the wrong issue!

We can close once someone accepts https://github.com/mlcommons/training/pull/601