search

mlcommons / training

Reference implementations of MLPerf™ training benchmarks
https://mlcommons.org/en/groups/training
Apache License 2.0
1.57k stars 548 forks source link

[SSD] Updated benchmark for for v2.0 #517

Closed ahmadki closed 2 years ago

github-actions[bot] commented 2 years ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

emizan76 commented 2 years ago

Just re-iterating my previous comment again to not remove the old SSD code, I think we should keep it around in an old_models folder or something similar.

ahmadki commented 2 years ago

Just re-iterating my previous comment again to not remove the old SSD code, I think we should keep it around in an old_models folder or something similar.

@emizan76 what is the advantage of keeping the benchmark in an "archive" folder opposed to git history ? @johntran-nv what do you think ?

emizan76 commented 2 years ago

Just re-iterating my previous comment again to not remove the old SSD code, I think we should keep it around in an old_models folder or something similar.

@emizan76 what is the advantage of keeping the benchmark in an "archive" folder opposed to git history ? @johntran-nv what do you think ?

Keeping an archive folder makes it easier for people to know what was there before. It will be hard for anyone not closely involved with the model to reliably retrieve the previous version from git logs in case it is needed.

johntran-nv commented 2 years ago

@bitfort could you merge this, please?