search

mlcommons / training

Reference implementations of MLPerf™ training benchmarks
https://mlcommons.org/en/groups/training
Apache License 2.0
1.57k stars 548 forks source link

minor fix to get object_detection working #539

Closed cometta closed 1 year ago

cometta commented 2 years ago

the object_detection only able to work after these minor changes. Fixed bug https://github.com/mlcommons/training/issues/383

github-actions[bot] commented 2 years ago

MLCommons CLA bot:
Thank you for your submission, we really appreciate it. We ask that you sign our MLCommons CLA and be a member before we can accept your contribution. If you are interested in membership, please contact membership@mlcommons.org .
0 out of 1 committers have signed the MLCommons CLA.
:x: @cometta
You can retrigger this bot by commenting recheck in this Pull Request

johntran-nv commented 1 year ago

@yuanzhedong could you review?

@cometta could you sign the CLA so we can merge this when ready? The form is here: https://mlcommons.org/en/get-involved/.

yuanzhedong commented 1 year ago

Hi @cometta could you try the latest master and see if it's already working? Your master is behind the latest master by several commits, which include the docker fix and extra params fix

johntran-nv commented 1 year ago

@cometta were you able to test the latest master?

cometta commented 1 year ago

sorry, i dont have bandwidth to look into this now.

johntran-nv commented 1 year ago

OK, if this isn't a priority for @cometta, the reference owners believe it's fixed, and this has been open a year, I think it's safe to close for now in our attempt to keep the git repo cleaner going forward. Feel free to reopen if this is still an issue. Thanks!