[MRCNN] remove ununsed argument

mlcommons / training

Reference implementations of MLPerf™ training benchmarks

https://mlcommons.org/en/groups/training

Apache License 2.0

1.57k stars 549 forks source link

[MRCNN] remove ununsed argument #556

Closed yuanzhedong closed 1 year ago

yuanzhedong commented 2 years ago

Fix this crash:

Traceback (most recent call last):
  File "tools/train_mlperf.py", line 309, in <module>
    main()
  File "tools/train_mlperf.py", line 298, in main
    model, success = train(cfg, args.local_rank, args.distributed, args.disable_allreduce_for_logging, random_number_generator)
AttributeError: 'Namespace' object has no attribute 'disable_allreduce_for_logging

github-actions[bot] commented 2 years ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

johntran-nv commented 1 year ago

Hi @erichan1 , this is another bug fix from an issue we found. Do you want to just merge as not risky?

johntran-nv commented 1 year ago

Defer to @erichan1 to merge, since this PR came from NV.

yuanzhedong commented 1 year ago

Thanks @johntran-nv @erichan1, this pr should fix this issue here

erichan1 commented 1 year ago

lgtm, merging.