[LLM] Initial version of the PaxML implementation

mlcommons / training

Reference implementations of MLPerf™ training benchmarks

https://mlcommons.org/en/groups/training

Apache License 2.0

1.6k stars 553 forks source link

Closed sgpyc closed 1 year ago

github-actions[bot] commented 2 years ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

nv-rborkar commented 1 year ago

Thanks @sgpyc ! Some comments about the Readme:

VM version v2-nightly-tpuv4 puts a "User does not have permission to access the OS image" error. Would something like v2-alpha-tpuv4 work?
Docker container (pax-dev:llm-ref) is not public. Would pip install of paxml, praxis work? Please update the readme if above suggestions work.

johntran-nv commented 1 year ago

@sgpyc are we ready to merge this? I can't tell if you addressed @nv-rborkar 's questions above with your latest commits.

sgpyc commented 1 year ago

@nv-rborkar & @johntran-nv : I updated the readme file after testing it on Cloud TPUs. Please take another look. Thanks.

nv-rborkar commented 1 year ago

Thanks @sgpyc , LGTM.